Yamamoto KadirandRégis Freyd
50005544ee
This normalizes all relationships and adds relations to models to take advantage of laravel's eagerloading and reduce queries to the database. This might go against the 'add any kind of complexities whatsoever' rule in the contribution guide, but I think adding relations would eventually simplify the code base. The amount of queries just on the dashboard fell from ~70 to 26. There's also a lot of boilerplate code in the Contact model to retrieve relationships and to maintain accurate count of them (fields like number_of_*). They can be greatly simplified with the addition of relations. One other thing in the Contact model was the definition of the Contact-User relation. This definition uses the account_id field in the contacts table and and relates it to id in users. I'm not sure if this is the intention, since the id from accounts table is used when assigning account_id for a contact. This seems to have worked so far, because both a user and its associated account are created at the same time during registration and their ids match, but if there was any difference, this relationship would relate wrong contacts and users. I changed the relationship name to account. This makes the path to a user from a contact is $contact->account->user right now.
59 lines
1.1 KiB
PHP
59 lines
1.1 KiB
PHP
<?php
|
|
|
|
namespace App;
|
|
|
|
use App\Helpers\DateHelper;
|
|
use Illuminate\Database\Eloquent\Model;
|
|
|
|
class Note extends Model
|
|
{
|
|
/**
|
|
* Get the account record associated with the note.
|
|
*/
|
|
public function account()
|
|
{
|
|
return $this->belongsTo('App\Account');
|
|
}
|
|
|
|
/**
|
|
* Get the contact record associated with the note.
|
|
*/
|
|
public function contact()
|
|
{
|
|
return $this->belongsTo('App\Contact');
|
|
}
|
|
|
|
/**
|
|
* Get the description of a note.
|
|
* @return string
|
|
*/
|
|
public function getBody()
|
|
{
|
|
if (is_null($this->body)) {
|
|
return null;
|
|
}
|
|
|
|
return $this->body;
|
|
}
|
|
|
|
/**
|
|
* Gets the activity date for this note.
|
|
*
|
|
* @param string $locale
|
|
* @return string
|
|
*/
|
|
public function getCreatedAt($locale)
|
|
{
|
|
return DateHelper::getShortDate($this->created_at, $locale);
|
|
}
|
|
|
|
/**
|
|
* Gets the content of the activity and formats it for the email.
|
|
* @return string
|
|
*/
|
|
public function getContent()
|
|
{
|
|
return wordwrap($this->getBody(), 75);
|
|
}
|
|
}
|