Ability to keep a local cache of icons (#16)

Daybreak/Configuration/ApplicationConfiguration.cs

@@ -37,5 +37,7 @@ namespace Daybreak.Configuration
         public bool PlaceShortcut { get; set; }
         [JsonProperty("AutoCheckUpdate")]
         public bool AutoCheckUpdate { get; set; } = true;
+        [JsonProperty("KeepLocalIconCache")]
+        public bool KeepLocalIconCache { get; set; } = true;
     }
 }

Daybreak/Daybreak.csproj

@@ -10,7 +10,7 @@
     <LangVersion>preview</LangVersion>
     <ApplicationIcon>Daybreak.ico</ApplicationIcon>
     <IncludePackageReferencesDuringMarkupCompilation>true</IncludePackageReferencesDuringMarkupCompilation>
-    <Version>0.9.1.1</Version>
+    <Version>0.9.2</Version>
   </PropertyGroup>
 
   <ItemGroup>

Daybreak/Services/IconRetrieve/IconRetriever.cs

@@ -1,4 +1,5 @@
 using Daybreak.Models.Builds;
+using Daybreak.Services.Configuration;
 using HtmlAgilityPack;
 using Microsoft.Extensions.Logging;
 using System;
@@ -15,20 +16,48 @@ namespace Daybreak.Services.IconRetrieve
         private const string NamePlaceholder = "[SKILLNAME]";
         private const string BaseUrl = "https://wiki.guildwars.com";
         private const string QueryUrl = $"wiki/File:{NamePlaceholder}.jpg";
+        private const string IconsDirectoryName = "Icons";
+        private const string IconsLocation = $"{IconsDirectoryName}/{NamePlaceholder}.jpg";
 
         private readonly IHttpClient<IconRetriever> httpClient;
         private readonly ILogger<IconRetriever> logger;
+        private readonly IConfigurationManager configurationManager;
 
         public IconRetriever(
             ILogger<IconRetriever> logger,
-            IHttpClient<IconRetriever> httpClient)
+            IHttpClient<IconRetriever> httpClient,
+            IConfigurationManager configurationManager)
         {
             this.logger = logger.ThrowIfNull(nameof(logger));
             this.httpClient = httpClient.ThrowIfNull(nameof(httpClient));
+            this.configurationManager = configurationManager.ThrowIfNull(nameof(configurationManager));
             this.httpClient.BaseAddress = new Uri(BaseUrl);
+            if (Directory.Exists(IconsDirectoryName) is false)
+            {
+                Directory.CreateDirectory(IconsDirectoryName);
+            }
         }
 
         public async Task<Optional<Stream>> GetIcon(Skill skill)
+        {
+            if (this.configurationManager.GetConfiguration().KeepLocalIconCache)
+            {
+                this.logger.LogInformation($"{nameof(IconRetriever)} configured to look first in cache before downloading icons");
+                var maybeIcon = await this.GetLocalIcon(skill);
+                if (maybeIcon.ExtractValue() is Stream stream)
+                {
+                    return stream;
+                }
+            }
+            else
+            {
+                this.logger.LogInformation($"{nameof(IconRetriever)} configured to skip local cache. Downloading icon");
+            }
+
+            return await this.DownloadIcon(skill);
+        }
+
+        private async Task<Optional<Stream>> DownloadIcon(Skill skill)
         {
             var curedSkillName = skill.Name
                 .Replace(" ", "_");
@@ -56,13 +85,42 @@ namespace Daybreak.Services.IconRetrieve
             if (response.IsSuccessStatusCode)
             {
                 this.logger.LogInformation("Retrieved latest icon stream");
-                return new MemoryStream(await iconResponse.Content.ReadAsByteArrayAsync());
+                var iconData = await iconResponse.Content.ReadAsByteArrayAsync();
+                if (this.configurationManager.GetConfiguration().KeepLocalIconCache)
+                {
+                    await this.SaveIconLocally(skill, iconData);
+                }
+                return new MemoryStream(iconData);
             }
 
             this.logger.LogError($"Failed to retrieve icon from {BaseUrl + "/" + url}");
             return Optional.None<Stream>();
         }
 
+        private async Task<Optional<Stream>> GetLocalIcon(Skill skill)
+        {
+            var curedSkillName = skill.Name
+                .Replace(" ", "_")
+                .Replace("\"", "");
+            this.logger.LogInformation("Checking local icon cache");
+            if (File.Exists(IconsLocation.Replace(NamePlaceholder, curedSkillName)))
+            {
+                this.logger.LogInformation("Local icon cache found. Retrieving icon");
+                return new MemoryStream(await File.ReadAllBytesAsync(IconsLocation.Replace(NamePlaceholder, curedSkillName)));
+            }
+
+            this.logger.LogWarning("No local icon cache found");
+            return Optional.None<Stream>();
+        }
+
+        private async Task SaveIconLocally(Skill skill, byte[] data)
+        {
+            var curedSkillName = skill.Name
+                .Replace(" ", "_")
+                .Replace("\"", "");
+            await File.WriteAllBytesAsync(IconsLocation.Replace(NamePlaceholder, curedSkillName), data);
+        }
+
         private static string GetHref(HtmlDocument doc)
         {
             foreach (var child in doc.DocumentNode.Descendants("a"))

Daybreak/Views/SettingsView.xaml

@@ -94,6 +94,7 @@
                 <TextBlock Text="Desired screen id: " FontSize="22" Foreground="White" Height="30"></TextBlock>
                 <TextBlock Text="Place Shortcut: " FontSize="22" Foreground="White" Height="30"></TextBlock>
                 <TextBlock Text="Shortcut folder: " FontSize="22" Foreground="White" Height="30"></TextBlock>
+                <TextBlock Text="Keep local cache of icons: " FontSize="22" Foreground="White" Height="30"></TextBlock>
             </StackPanel>
             <StackPanel Orientation="Vertical" Grid.Row="1" Grid.Column="1">
                 <ToggleButton HorizontalAlignment="Center" HorizontalContentAlignment="Stretch" Style="{StaticResource AnimatedSwitch}" Height="30" Width="40"
@@ -148,6 +149,8 @@
                                       Foreground="White" BorderBrush="Gray" BorderThickness="0"
                                       Clicked="ShortcutFolderPickerGlyph_Clicked"></controls:FilePickerGlyph>
                 </Grid>
+                <ToggleButton HorizontalAlignment="Center" HorizontalContentAlignment="Stretch" Style="{StaticResource AnimatedSwitch}" Height="30" Width="40"
+                            FontSize="22" Foreground="White" IsChecked="{Binding ElementName=_this, Path=KeepLocalIconCache, Mode=TwoWay}"></ToggleButton>
             </StackPanel>
         </Grid>
     </ScrollViewer>

Daybreak/Views/SettingsView.xaml.cs

@@ -45,6 +45,8 @@ namespace Daybreak.Views
         private bool shortcutPlaced;
         [GenerateDependencyProperty]
         private bool autoCheckUpdate;
+        [GenerateDependencyProperty]
+        private bool keepLocalIconCache;
 
         public SettingsView(
             IConfigurationManager configurationManager,
@@ -71,6 +73,7 @@ namespace Daybreak.Views
             this.ShortcutFolder = config.ShortcutLocation;
             this.ShortcutPlaced = config.PlaceShortcut;
             this.AutoCheckUpdate = config.AutoCheckUpdate;
+            this.KeepLocalIconCache = config.KeepLocalIconCache;
         }
 
         private void SaveButton_Clicked(object sender, EventArgs e)
@@ -88,6 +91,7 @@ namespace Daybreak.Views
             currentConfig.ShortcutLocation = this.ShortcutFolder;
             currentConfig.PlaceShortcut = this.ShortcutPlaced;
             currentConfig.AutoCheckUpdate = this.AutoCheckUpdate;
+            currentConfig.KeepLocalIconCache = this.KeepLocalIconCache;
             this.configurationManager.SaveConfiguration(currentConfig);
             this.viewManager.ShowView<SettingsCategoryView>();
         }