+
{{ note.emotion.name }}
@@ -155,20 +159,11 @@
-
-
- {{ note.author }}
+
+
+
+
{{ note.author.name }}
+
diff --git a/resources/js/Shared/Modules/Tasks.vue b/resources/js/Shared/Modules/Tasks.vue
index 73e9e8da0..090fc3ec0 100644
--- a/resources/js/Shared/Modules/Tasks.vue
+++ b/resources/js/Shared/Modules/Tasks.vue
@@ -19,6 +19,10 @@
border-bottom-right-radius: 8px;
}
}
+
+input[type='checkbox'] {
+ top: -1px;
+}
@@ -43,7 +47,7 @@
Tasks
-
+
diff --git a/resources/lang/en/contact.php b/resources/lang/en/contact.php
new file mode 100644
index 000000000..6c101dab0
--- /dev/null
+++ b/resources/lang/en/contact.php
@@ -0,0 +1,15 @@
+ 'Deleted user',
+ 'feed_item_contact_information_updated' => 'updated the contact information',
+ 'feed_item_important_date_created' => 'added an important date',
+ 'feed_item_important_date_updated' => 'updated an important date',
+ 'feed_item_important_date_destroyed' => 'deleted an important date',
+ 'feed_item_label_assigned' => 'assigned a label',
+ 'feed_item_label_removed' => 'removed a label',
+ 'feed_item_note_created' => 'wrote a note',
+ 'feed_item_note_updated' => 'edited a note',
+ 'feed_item_note_destroyed' => 'deleted a note',
+ 'feed_item_job_information_updated' => 'updated the job information',
+];
diff --git a/tests/TestCase.php b/tests/TestCase.php
index 45d1293fd..2163aaf25 100644
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -3,6 +3,7 @@
namespace Tests;
use App\Models\Account;
+use App\Models\Contact;
use App\Models\User;
use App\Models\Vault;
use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
@@ -63,7 +64,10 @@ abstract class TestCase extends BaseTestCase
*/
public function setPermissionInVault(User $user, int $permission, Vault $vault): Vault
{
- $vault->users()->sync([$user->id => ['permission' => $permission]]);
+ $contact = Contact::factory()->create([
+ 'vault_id' => $vault->id,
+ ]);
+ $vault->users()->sync([$user->id => ['permission' => $permission, 'contact_id' => $contact->id]]);
return $vault;
}
diff --git a/tests/Unit/Domains/Contact/ManageContactFeed/Web/ViewHelpers/ModuleFeedViewHelperTest.php b/tests/Unit/Domains/Contact/ManageContactFeed/Web/ViewHelpers/ModuleFeedViewHelperTest.php
index 1d09f988a..2cfa6f8c3 100644
--- a/tests/Unit/Domains/Contact/ManageContactFeed/Web/ViewHelpers/ModuleFeedViewHelperTest.php
+++ b/tests/Unit/Domains/Contact/ManageContactFeed/Web/ViewHelpers/ModuleFeedViewHelperTest.php
@@ -37,6 +37,6 @@ class ModuleFeedViewHelperTest extends TestCase
$this->assertArrayHasKey('items', $array);
$this->assertArrayHasKey('id', $array['items']->toArray()[0]);
$this->assertArrayHasKey('action', $array['items']->toArray()[0]);
- $this->assertArrayHasKey('object', $array['items']->toArray()[0]);
+ $this->assertArrayHasKey('description', $array['items']->toArray()[0]);
}
}
diff --git a/tests/Unit/Domains/Contact/ManageNotes/Services/CreateNoteTest.php b/tests/Unit/Domains/Contact/ManageNotes/Services/CreateNoteTest.php
index ff9df01ad..5749071f4 100644
--- a/tests/Unit/Domains/Contact/ManageNotes/Services/CreateNoteTest.php
+++ b/tests/Unit/Domains/Contact/ManageNotes/Services/CreateNoteTest.php
@@ -101,7 +101,6 @@ class CreateNoteTest extends TestCase
'id' => $note->id,
'contact_id' => $contact->id,
'author_id' => $author->id,
- 'author_name' => $author->name,
'title' => 'super title',
'body' => 'super body',
]);
diff --git a/tests/Unit/Domains/Contact/ManageNotes/Services/DestroyNoteTest.php b/tests/Unit/Domains/Contact/ManageNotes/Services/DestroyNoteTest.php
index 6ce16fee7..0872fbb97 100644
--- a/tests/Unit/Domains/Contact/ManageNotes/Services/DestroyNoteTest.php
+++ b/tests/Unit/Domains/Contact/ManageNotes/Services/DestroyNoteTest.php
@@ -133,11 +133,6 @@ class DestroyNoteTest extends TestCase
'id' => $note->id,
]);
- $this->assertDatabaseMissing('contact_feed_items', [
- 'contact_id' => $contact->id,
- 'feedable_id' => $note->id,
- ]);
-
Queue::assertPushed(CreateAuditLog::class, function ($job) {
return $job->auditLog['action_name'] === 'note_destroyed';
});
diff --git a/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/ModuleNotesViewHelperTest.php b/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/ModuleNotesViewHelperTest.php
index 0fa614ba5..6f5d4cdff 100644
--- a/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/ModuleNotesViewHelperTest.php
+++ b/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/ModuleNotesViewHelperTest.php
@@ -80,7 +80,7 @@ class ModuleNotesViewHelperTest extends TestCase
'show_full_content' => false,
'title' => $note->title,
'emotion' => null,
- 'author' => $note->author->name,
+ 'author' => null,
'written_at' => 'Jan 01, 2018',
'url' => [
'update' => env('APP_URL').'/vaults/'.$contact->vault->id.'/contacts/'.$contact->id.'/notes/'.$note->id,
diff --git a/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/NotesIndexViewHelperTest.php b/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/NotesIndexViewHelperTest.php
index 981e3dadc..9f7aada55 100644
--- a/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/NotesIndexViewHelperTest.php
+++ b/tests/Unit/Domains/Contact/ManageNotes/Web/ViewHelpers/NotesIndexViewHelperTest.php
@@ -91,7 +91,7 @@ class NotesIndexViewHelperTest extends TestCase
'show_full_content' => false,
'title' => $note->title,
'emotion' => null,
- 'author' => $note->author->name,
+ 'author' => null,
'written_at' => 'Jan 01, 2018',
'url' => [
'update' => env('APP_URL').'/vaults/'.$contact->vault->id.'/contacts/'.$contact->id.'/notes/'.$note->id,
diff --git a/tests/Unit/Domains/Settings/ManageUsers/Services/DestroyUserTest.php b/tests/Unit/Domains/Settings/ManageUsers/Services/DestroyUserTest.php
index a9bc4c2a3..3b9eaafbe 100644
--- a/tests/Unit/Domains/Settings/ManageUsers/Services/DestroyUserTest.php
+++ b/tests/Unit/Domains/Settings/ManageUsers/Services/DestroyUserTest.php
@@ -5,6 +5,7 @@ namespace Tests\Unit\Domains\Settings\ManageUsers\Services;
use App\Exceptions\NotEnoughPermissionException;
use App\Jobs\CreateAuditLog;
use App\Models\Account;
+use App\Models\Contact;
use App\Models\User;
use App\Models\Vault;
use App\Settings\ManageUsers\Services\DestroyUser;
@@ -35,24 +36,29 @@ class DestroyUserTest extends TestCase
]);
$vaultManager->users()->save($user, [
'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$vaultEditor = Vault::factory()->create([
'account_id' => $author->account_id,
]);
$vaultEditor->users()->save($user, [
'permission' => Vault::PERMISSION_EDIT,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$vaultEditor->users()->save(User::factory()->create(), [
'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$vaultViewer = Vault::factory()->create([
'account_id' => $author->account_id,
]);
$vaultViewer->users()->save($user, [
'permission' => Vault::PERMISSION_VIEW,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$vaultViewer->users()->save(User::factory()->create(), [
'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$this->executeService($author->account, $author, $user, $vaultManager, $vaultEditor, $vaultViewer);
diff --git a/tests/Unit/Domains/Vault/ManageVault/Web/ViewHelpers/VaultIndexViewHelperTest.php b/tests/Unit/Domains/Vault/ManageVault/Web/ViewHelpers/VaultIndexViewHelperTest.php
index f74951076..fb443f4a1 100644
--- a/tests/Unit/Domains/Vault/ManageVault/Web/ViewHelpers/VaultIndexViewHelperTest.php
+++ b/tests/Unit/Domains/Vault/ManageVault/Web/ViewHelpers/VaultIndexViewHelperTest.php
@@ -2,6 +2,7 @@
namespace Tests\Unit\Domains\Vault\ManageVault\Web\ViewHelpers;
+use App\Models\Contact;
use App\Models\User;
use App\Models\Vault;
use App\Vault\ManageVault\Web\ViewHelpers\VaultIndexViewHelper;
@@ -20,6 +21,7 @@ class VaultIndexViewHelperTest extends TestCase
$vault = Vault::factory()->create();
$user->vaults()->attach($vault->id, [
'permission' => Vault::PERMISSION_EDIT,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$this->be($user);
@@ -69,7 +71,10 @@ class VaultIndexViewHelperTest extends TestCase
$vault = Vault::factory()->create([
'account_id' => $user->account_id,
]);
- $user->vaults()->sync([$vault->id => ['permission' => Vault::PERMISSION_MANAGE]]);
+ $user->vaults()->sync([$vault->id => [
+ 'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
+ ]]);
$array = VaultIndexViewHelper::data($user);
diff --git a/tests/Unit/Domains/Vault/ManageVaultSettings/Services/ChangeVaultAccessTest.php b/tests/Unit/Domains/Vault/ManageVaultSettings/Services/ChangeVaultAccessTest.php
index fced380e6..ef00c869c 100644
--- a/tests/Unit/Domains/Vault/ManageVaultSettings/Services/ChangeVaultAccessTest.php
+++ b/tests/Unit/Domains/Vault/ManageVaultSettings/Services/ChangeVaultAccessTest.php
@@ -5,6 +5,7 @@ namespace Tests\Unit\Domains\Vault\ManageVaultSettings\Services;
use App\Exceptions\NotEnoughPermissionException;
use App\Jobs\CreateAuditLog;
use App\Models\Account;
+use App\Models\Contact;
use App\Models\User;
use App\Models\Vault;
use App\Vault\ManageVaultSettings\Services\ChangeVaultAccess;
@@ -29,6 +30,7 @@ class ChangeVaultAccessTest extends TestCase
$vault = $this->setPermissionInVault($regis, Vault::PERMISSION_MANAGE, $vault);
$vault->users()->save($anotherUser, [
'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$this->executeService($regis->account, $regis, $anotherUser, $vault);
}
diff --git a/tests/Unit/Domains/Vault/ManageVaultSettings/Services/GrantVaultAccessToUserTest.php b/tests/Unit/Domains/Vault/ManageVaultSettings/Services/GrantVaultAccessToUserTest.php
index 205462af8..0adee2a1e 100644
--- a/tests/Unit/Domains/Vault/ManageVaultSettings/Services/GrantVaultAccessToUserTest.php
+++ b/tests/Unit/Domains/Vault/ManageVaultSettings/Services/GrantVaultAccessToUserTest.php
@@ -131,7 +131,7 @@ class GrantVaultAccessToUserTest extends TestCase
$user = (new GrantVaultAccessToUser)->execute($request);
- $this->assertDatabaseCount('contacts', 2);
+ $this->assertDatabaseCount('contacts', 3);
$contact = Contact::where('first_name', $anotherUser->first_name)->first();
diff --git a/tests/Unit/Domains/Vault/ManageVaultSettings/Web/ViewHelpers/VaultSettingsIndexViewHelperTest.php b/tests/Unit/Domains/Vault/ManageVaultSettings/Web/ViewHelpers/VaultSettingsIndexViewHelperTest.php
index cb9b67ee9..ca8ce30c9 100644
--- a/tests/Unit/Domains/Vault/ManageVaultSettings/Web/ViewHelpers/VaultSettingsIndexViewHelperTest.php
+++ b/tests/Unit/Domains/Vault/ManageVaultSettings/Web/ViewHelpers/VaultSettingsIndexViewHelperTest.php
@@ -2,6 +2,7 @@
namespace Tests\Unit\Domains\Vault\ManageVaultSettings\Web\ViewHelpers;
+use App\Models\Contact;
use App\Models\Label;
use App\Models\Template;
use App\Models\User;
@@ -28,7 +29,7 @@ class VaultSettingsIndexViewHelperTest extends TestCase
$vault = Vault::factory()->create([
'account_id' => $template->account_id,
]);
- $vault->users()->sync([$userInVault->id => ['permission' => 100]]);
+ $vault->users()->sync([$userInVault->id => ['permission' => 100, 'contact_id' => Contact::factory()->create()->id]]);
$array = VaultSettingsIndexViewHelper::data($vault);
$this->assertCount(
diff --git a/tests/Unit/Helpers/UserHelperTest.php b/tests/Unit/Helpers/UserHelperTest.php
new file mode 100644
index 000000000..2d7e4d6b8
--- /dev/null
+++ b/tests/Unit/Helpers/UserHelperTest.php
@@ -0,0 +1,62 @@
+create();
+ $vault = Vault::factory()->create([
+ 'account_id' => $rachel->account_id,
+ ]);
+ $contact = Contact::factory()->create([
+ 'vault_id' => $vault->id,
+ 'first_name' => 'Keanu',
+ 'last_name' => 'Reeves',
+ ]);
+ $avatar = Avatar::factory()->create([
+ 'contact_id' => $contact->id,
+ ]);
+ $contact->avatar_id = $avatar->id;
+ $contact->save();
+ $vault->users()->save($rachel, [
+ 'permission' => 1,
+ 'contact_id' => $contact->id,
+ ]);
+
+ $this->assertEquals(
+ [
+ 'id' => $contact->id,
+ 'name' => 'Keanu Reeves',
+ 'avatar' => AvatarHelper::getSVG($contact),
+ ],
+ UserHelper::getInformationAboutContact($rachel, $vault)
+ );
+ }
+
+ /** @test */
+ public function it_returns_null_if_the_user_doesnt_have_a_contact_in_the_vault(): void
+ {
+ $rachel = User::factory()->create();
+ $vault = Vault::factory()->create([
+ 'account_id' => $rachel->account_id,
+ ]);
+
+ $this->assertNull(
+ UserHelper::getInformationAboutContact($rachel, $vault)
+ );
+ }
+}
diff --git a/tests/Unit/Helpers/VaultHelperTest.php b/tests/Unit/Helpers/VaultHelperTest.php
index ba8669419..437b2b989 100644
--- a/tests/Unit/Helpers/VaultHelperTest.php
+++ b/tests/Unit/Helpers/VaultHelperTest.php
@@ -3,6 +3,7 @@
namespace Tests\Unit\Helpers;
use App\Helpers\VaultHelper;
+use App\Models\Contact;
use App\Models\User;
use App\Models\Vault;
use Illuminate\Foundation\Testing\DatabaseTransactions;
@@ -38,6 +39,7 @@ class VaultHelperTest extends TestCase
$vault = Vault::factory()->create();
$user->vaults()->attach($vault->id, [
'permission' => Vault::PERMISSION_VIEW,
+ 'contact_id' => Contact::factory()->create()->id,
]);
$this->assertEquals(
diff --git a/tests/Unit/Models/ContactFeedItemTest.php b/tests/Unit/Models/ContactFeedItemTest.php
index 0eac67973..aefd47d8e 100644
--- a/tests/Unit/Models/ContactFeedItemTest.php
+++ b/tests/Unit/Models/ContactFeedItemTest.php
@@ -10,6 +10,14 @@ class ContactFeedItemTest extends TestCase
{
use DatabaseTransactions;
+ /** @test */
+ public function it_has_one_user()
+ {
+ $feedItem = ContactFeedItem::factory()->create();
+
+ $this->assertTrue($feedItem->author()->exists());
+ }
+
/** @test */
public function it_has_one_contact()
{
diff --git a/tests/Unit/Models/UserTest.php b/tests/Unit/Models/UserTest.php
index 4a9a7cf8a..cdd7fa745 100644
--- a/tests/Unit/Models/UserTest.php
+++ b/tests/Unit/Models/UserTest.php
@@ -31,7 +31,10 @@ class UserTest extends TestCase
'account_id' => $regis->account_id,
]);
- $regis->vaults()->sync([$vault->id => ['permission' => Vault::PERMISSION_MANAGE]]);
+ $regis->vaults()->sync([$vault->id => [
+ 'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
+ ]]);
$this->assertTrue($regis->vaults()->exists());
}
@@ -105,5 +108,10 @@ class UserTest extends TestCase
$contact->id,
$rachel->getContactInVault($vault)->id,
);
+
+ $robert = User::factory()->create();
+ $this->assertNull(
+ $robert->getContactInVault($vault),
+ );
}
}
diff --git a/tests/Unit/Models/VaultTest.php b/tests/Unit/Models/VaultTest.php
index 0aa48f8cb..e8579bef2 100644
--- a/tests/Unit/Models/VaultTest.php
+++ b/tests/Unit/Models/VaultTest.php
@@ -42,7 +42,10 @@ class VaultTest extends TestCase
'account_id' => $dwight->account_id,
]);
- $vault->users()->sync([$dwight->id => ['permission' => Vault::PERMISSION_MANAGE]]);
+ $vault->users()->sync([$dwight->id => [
+ 'permission' => Vault::PERMISSION_MANAGE,
+ 'contact_id' => Contact::factory()->create()->id,
+ ]]);
$this->assertTrue($vault->users()->exists());
}