amacocian/monica
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: fix bad return types with Psalter (#2435)

Browse Source
This commit is contained in:
Matthew Brown
2019-02-16 19:20:28 +01:00
committed by Alexis Saettler
parent e04de7e101
commit 684ce6bc56
90 changed files with 774 additions and 503 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Contacts/AddressesController.php
+2 -1
View File
@@ -103,7 +103,8 @@ class AddressesController extends Controller
* @param Request $request
* @param Contact $contact
* @param Address $address
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\JsonResponse
*/
public function destroy(Request $request, Contact $contact, Address $address)
{
app/Http/Controllers/Contacts/CallsController.php
+5 -3
View File
@@ -19,8 +19,9 @@ class CallsController extends Controller
/**
* Display the list of calls.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
*/
public function index(Request $request, Contact $contact)
{
@@ -72,7 +73,8 @@ class CallsController extends Controller
* @param Request $request
* @param Contact $contact
* @param Call $call
* @return \Illuminate\Http\Response
*
* @return null|\Illuminate\Http\JsonResponse
*/
public function destroy(Request $request, Contact $contact, Call $call)
{
app/Http/Controllers/Contacts/ConversationsController.php
+12 -7
View File
@@ -22,8 +22,9 @@ class ConversationsController extends Controller
/**
* Display the Create conversation page.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\View\View
*/
public function create(Request $request, Contact $contact)
{
@@ -65,7 +66,8 @@ class ConversationsController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function store(Request $request, Contact $contact)
{
@@ -123,8 +125,9 @@ class ConversationsController extends Controller
/**
* Display a specific conversation.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\View\View
*/
public function edit(Request $request, Contact $contact, Conversation $conversation)
{
@@ -151,7 +154,8 @@ class ConversationsController extends Controller
* @param Request $request
* @param Contact $contact
* @param Conversation $conversation
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function update(Request $request, Contact $contact, Conversation $conversation)
{
@@ -222,7 +226,8 @@ class ConversationsController extends Controller
* @param Request $request
* @param Contact $contact
* @param Conversation $conversation
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
*/
public function destroy(Request $request, Contact $contact, Conversation $conversation)
{
app/Http/Controllers/Contacts/DebtController.php
+15 -8
View File
@@ -14,7 +14,8 @@ class DebtController extends Controller
* Display a listing of the resource.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function index(Contact $contact)
{
@@ -26,7 +27,8 @@ class DebtController extends Controller
* Show the form for creating a new resource.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function create(Contact $contact)
{
@@ -41,7 +43,8 @@ class DebtController extends Controller
*
* @param DebtRequest $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function store(DebtRequest $request, Contact $contact)
{
@@ -66,9 +69,10 @@ class DebtController extends Controller
*
* @param Contact $contact
* @param Debt $debt
* @return \Illuminate\Http\Response
*
* @return void
*/
public function show(Contact $contact, Debt $debt)
public function show(Contact $contact, Debt $debt): void
{
//
}
@@ -78,7 +82,8 @@ class DebtController extends Controller
*
* @param Contact $contact
* @param Debt $debt
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function edit(Contact $contact, Debt $debt)
{
@@ -94,7 +99,8 @@ class DebtController extends Controller
* @param DebtRequest $request
* @param Contact $contact
* @param Debt $debt
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function update(DebtRequest $request, Contact $contact, Debt $debt)
{
@@ -119,7 +125,8 @@ class DebtController extends Controller
*
* @param Contact $contact
* @param Debt $debt
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function destroy(Contact $contact, Debt $debt)
{
app/Http/Controllers/Contacts/DocumentsController.php
+8 -5
View File
@@ -18,8 +18,9 @@ class DocumentsController extends Controller
/**
* Display the list of documents.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
*/
public function index(Request $request, Contact $contact)
{
@@ -33,9 +34,10 @@ class DocumentsController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return Document
*/
public function store(Request $request, Contact $contact)
public function store(Request $request, Contact $contact): Document
{
return app(UploadDocument::class)->execute([
'account_id' => auth()->user()->account->id,
@@ -50,7 +52,8 @@ class DocumentsController extends Controller
* @param Request $request
* @param Contact $contact
* @param Document $document
* @return \Illuminate\Http\Response
*
* @return null|\Illuminate\Http\JsonResponse
*/
public function destroy(Request $request, Contact $contact, Document $document)
{
app/Http/Controllers/Contacts/GiftsController.php
+15 -8
View File
@@ -16,7 +16,8 @@ class GiftsController extends Controller
* List all the gifts for the given contact.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Support\Collection
*/
public function index(Contact $contact)
{
@@ -71,7 +72,8 @@ class GiftsController extends Controller
* Show the form for creating a new resource.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function create(Contact $contact)
{
@@ -89,7 +91,8 @@ class GiftsController extends Controller
*
* @param GiftsRequest $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function store(GiftsRequest $request, Contact $contact)
{
@@ -104,7 +107,8 @@ class GiftsController extends Controller
*
* @param Contact $contact
* @param Gift $gift
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function edit(Contact $contact, Gift $gift)
{
@@ -123,7 +127,8 @@ class GiftsController extends Controller
* @param GiftsRequest $request
* @param Contact $contact
* @param Gift $gift
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function update(GiftsRequest $request, Contact $contact, Gift $gift)
{
@@ -138,9 +143,10 @@ class GiftsController extends Controller
*
* @param Contact $contact
* @param Gift $gift
* @return \Illuminate\Http\Response
*
* @return void
*/
public function destroy(Contact $contact, Gift $gift)
public function destroy(Contact $contact, Gift $gift): void
{
$gift->delete();
}
@@ -150,7 +156,8 @@ class GiftsController extends Controller
*
* @param GiftsRequest $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Database\Eloquent\Model
*/
public function updateOrCreate(GiftsRequest $request, Contact $contact, Gift $gift = null)
{
app/Http/Controllers/Contacts/IntroductionsController.php
+4 -2
View File
@@ -18,7 +18,8 @@ class IntroductionsController extends Controller
* Show the form for editing the specified resource.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function edit(Contact $contact)
{
@@ -31,7 +32,8 @@ class IntroductionsController extends Controller
*
* @param IntroductionsRequest $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
*/
public function update(IntroductionsRequest $request, Contact $contact)
{
app/Http/Controllers/Contacts/LifeEventsController.php
+11 -7
View File
@@ -49,9 +49,10 @@ class LifeEventsController extends Controller
/**
* Display the list of life events.
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Request $request
* @param Contact $contact
*
* @return Collection
*/
public function index(Request $request, Contact $contact)
{
@@ -78,7 +79,8 @@ class LifeEventsController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return LifeEvent|\Illuminate\Http\RedirectResponse
*/
public function store(Request $request, Contact $contact)
{
@@ -108,9 +110,11 @@ class LifeEventsController extends Controller
/**
* Destroy the life event.
* @param Request $request
* @param LifeEvent $lifeEvent
* @return \Illuminate\Http\Response
*
* @param Request $request
* @param LifeEvent $lifeEvent
*
* @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
*/
public function destroy(Request $request, LifeEvent $lifeEvent)
{
app/Http/Controllers/Contacts/NotesController.php
+6 -4
View File
@@ -68,9 +68,10 @@ class NotesController extends Controller
* @param NotesRequest $request
* @param Contact $contact
* @param Note $note
* @return \Illuminate\Http\Response
*
* @return Note
*/
public function update(NotesRequest $request, Contact $contact, Note $note)
public function update(NotesRequest $request, Contact $contact, Note $note): Note
{
$note->update(
$request->only([
@@ -87,9 +88,10 @@ class NotesController extends Controller
*
* @param Contact $contact
* @param Note $note
* @return \Illuminate\Http\Response
*
* @return void
*/
public function destroy(Contact $contact, Note $note)
public function destroy(Contact $contact, Note $note): void
{
$note->delete();
}
app/Http/Controllers/Contacts/PhotosController.php
+8 -5
View File
@@ -18,8 +18,9 @@ class PhotosController extends Controller
/**
* Display the list of photos.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
*/
public function index(Request $request, Contact $contact)
{
@@ -33,9 +34,10 @@ class PhotosController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return PhotoResource
*/
public function store(Request $request, Contact $contact)
public function store(Request $request, Contact $contact): PhotoResource
{
$photo = app(UploadPhoto::class)->execute([
'account_id' => auth()->user()->account->id,
@@ -55,7 +57,8 @@ class PhotosController extends Controller
* @param Request $request
* @param Contact $contact
* @param Photo $photo
* @return \Illuminate\Http\Response
*
* @return null|\Illuminate\Http\JsonResponse
*/
public function destroy(Request $request, Contact $contact, Photo $photo)
{
app/Http/Controllers/Contacts/RelationshipsController.php
+11 -6
View File
@@ -15,8 +15,9 @@ class RelationshipsController extends Controller
/**
* Display the Create relationship page.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
* @param Contact $contact
*
* @return \Illuminate\View\View
*/
public function create(Request $request, Contact $contact)
{
@@ -69,7 +70,8 @@ class RelationshipsController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function store(Request $request, Contact $contact)
{
@@ -169,7 +171,8 @@ class RelationshipsController extends Controller
*
* @param Contact $contact
* @param Contact $otherContact significant other contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function edit(Contact $contact, Contact $otherContact)
{
@@ -216,7 +219,8 @@ class RelationshipsController extends Controller
* @param Request $request
* @param Contact $contact
* @param Contact $otherContact significant other contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function update(Request $request, Contact $contact, Contact $otherContact)
{
@@ -287,7 +291,8 @@ class RelationshipsController extends Controller
*
* @param Contact $contact
* @param Contact $otherContact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function destroy(Contact $contact, Contact $otherContact)
{
app/Http/Controllers/Contacts/RemindersController.php
+10 -5
View File
@@ -17,7 +17,8 @@ class RemindersController extends Controller
* Show the form for creating a new reminder.
*
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function create(Contact $contact)
{
@@ -32,7 +33,8 @@ class RemindersController extends Controller
*
* @param Request $request
* @param Contact $contact
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function store(Request $request, Contact $contact)
{
@@ -57,7 +59,8 @@ class RemindersController extends Controller
*
* @param Contact $contact
* @param Reminder $reminder
* @return \Illuminate\Http\Response
*
* @return \Illuminate\View\View
*/
public function edit(Contact $contact, Reminder $reminder)
{
@@ -73,7 +76,8 @@ class RemindersController extends Controller
* @param Request $request
* @param Contact $contact
* @param Reminder $reminder
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function update(Request $request, Contact $contact, Reminder $reminder)
{
@@ -100,7 +104,8 @@ class RemindersController extends Controller
* @param Request $request
* @param Contact $contact
* @param Reminder $reminder
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\RedirectResponse
*/
public function destroy(Request $request, Contact $contact, Reminder $reminder)
{
app/Http/Controllers/Contacts/TagsController.php
+6 -4
View File
@@ -15,7 +15,8 @@ class TagsController extends Controller
* Get the list of all the tags in the account.
*
* @param Request $request
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
*/
public function index(Request $request)
{
@@ -28,7 +29,8 @@ class TagsController extends Controller
* Get the list of all the tags for this contact.
*
* @param Request $request
* @return \Illuminate\Http\Response
*
* @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
*/
public function get(Request $request, Contact $contact)
{
@@ -43,9 +45,9 @@ class TagsController extends Controller
* @param Request $request
* @param Contact $contact
*
* @return \Illuminate\Http\Response
* @return void
*/
public function update(Request $request, Contact $contact)
public function update(Request $request, Contact $contact): void
{
$tags = $request->all();