refactor: fix bad return types with Psalter (#2435)

app/Http/Controllers/Api/ApiNoteController.php

@@ -15,7 +15,7 @@ class ApiNoteController extends ApiController
     /**
      * Get the list of notes.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection|\Illuminate\Http\JsonResponse
      */
     public function index(Request $request)
     {
@@ -32,8 +32,10 @@ class ApiNoteController extends ApiController
 
     /**
      * Get the detail of a given note.
-     * @param  Request $request
-     * @return \Illuminate\Http\Response
+     *
+     * @param Request $request
+     *
+     * @return NoteResource|\Illuminate\Http\JsonResponse
      */
     public function show(Request $request, $id)
     {
@@ -50,8 +52,10 @@ class ApiNoteController extends ApiController
 
     /**
      * Store the note.
-     * @param  Request $request
-     * @return \Illuminate\Http\Response
+     *
+     * @param Request $request
+     *
+     * @return NoteResource|\Illuminate\Http\JsonResponse
      */
     public function store(Request $request)
     {
@@ -79,9 +83,11 @@ class ApiNoteController extends ApiController
 
     /**
      * Update the note.
-     * @param  Request $request
-     * @param  int $noteId
-     * @return \Illuminate\Http\Response
+     *
+     * @param Request $request
+     * @param int $noteId
+     *
+     * @return NoteResource|\Illuminate\Http\JsonResponse
      */
     public function update(Request $request, $noteId)
     {
@@ -118,7 +124,7 @@ class ApiNoteController extends ApiController
      * Validate the request for update.
      *
      * @param  Request $request
-     * @return mixed
+     * @return \Illuminate\Http\JsonResponse|true
      */
     private function validateUpdate(Request $request)
     {
@@ -146,8 +152,10 @@ class ApiNoteController extends ApiController
 
     /**
      * Delete a note.
-     * @param  Request $request
-     * @return \Illuminate\Http\Response
+     *
+     * @param Request $request
+     *
+     * @return \Illuminate\Http\JsonResponse
      */
     public function destroy(Request $request, $noteId)
     {
@@ -167,7 +175,7 @@ class ApiNoteController extends ApiController
     /**
      * Get the list of notes for the given contact.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection|\Illuminate\Http\JsonResponse
      */
     public function notes(Request $request, $contactId)
     {