feat: refactor how activities are managed and displayed (#2299)

app/Http/Controllers/Contacts/ActivitiesController.php

@@ -5,11 +5,22 @@ namespace App\Http\Controllers\Contacts;
 use Carbon\Carbon;
 use Illuminate\Http\Request;
 use App\Models\Contact\Contact;
+use App\Models\Account\Activity;
+use Illuminate\Support\Collection;
 use App\Http\Controllers\Controller;
+use App\Models\Account\ActivityType;
+use App\Traits\JsonRespondController;
+use Illuminate\Database\Eloquent\ModelNotFoundException;
+use App\Services\Account\Activity\Activity\CreateActivity;
+use App\Services\Account\Activity\Activity\DestroyActivity;
 use App\Services\Account\Activity\ActivityStatisticService;
+use App\Http\Resources\Activity\Activity as ActivityResource;
+use App\Services\Account\Activity\Activity\AttachContactToActivity;
 
 class ActivitiesController extends Controller
 {
+    use JsonRespondController;
+
     /**
      * Statistics about an activity.
      *
@@ -23,12 +34,156 @@ class ActivitiesController extends Controller
     }
 
     /**
-     * Get all the activities for this contact.
+     * Get the list of activities.
+     *
+     * @param Request $request
+     * @param Contact $contact
+     * @return \Illuminate\Http\Resources\Json\ResourceCollection
      */
-    public function index(Contact $contact)
+    public function index(Request $request, Contact $contact)
+    {
+        $activities = $contact->activities()
+                            ->orderBy('happened_at', 'desc')
+                            ->limit(10)
+                            ->get();
+
+        return ActivityResource::collection($activities);
+    }
+
+    /**
+     * Get the list of contacts available to associate the activity with
+     * participants.
+     * We could have chosen to query `/people` to get the full list of contacts
+     * but some accounts have thousands of contacts. Thus for performance
+     * purposes we have to create our own collection containing just the
+     * necessary information.
+     * Also we need to filter out the current contact from the list.
+     *
+     * @param Request $request
+     * @param Contact $contact
+     * @return Collection
+     */
+    public function contacts(Request $request, Contact $contact)
+    {
+        $contactsCollection = collect([]);
+        $contacts = auth()->user()->account->contacts;
+
+        foreach ($contacts as $singleContact) {
+            if ($contact->id != $singleContact->id) {
+                $contactsCollection->push([
+                    'id' => $singleContact->id,
+                    'name' => $singleContact->name,
+                ]);
+            }
+        }
+
+        return $contactsCollection;
+    }
+
+    /**
+     * Store an activity.
+     *
+     * @param  Contact $contact
+     * @return ActivityResource|\Illuminate\Http\JsonResponse
+     */
+    public function store(Request $request, Contact $contact)
+    {
+        $activity = app(CreateActivity::class)->execute([
+            'account_id' => auth()->user()->account->id,
+            'activity_type_id' => $request->input('activity_type_id'),
+            'summary' => $request->input('summary'),
+            'description' => $request->input('description'),
+            'date' => $request->input('happened_at'),
+            'emotions' => $request->input('emotions'),
+        ]);
+
+        $arrayParticipants = array_map(function ($participant) {
+            return $participant['id'];
+        }, $request->input('participants'));
+        // also push the current contact
+        array_push($arrayParticipants, $contact->id);
+
+        try {
+            $activity = app(AttachContactToActivity::class)->execute([
+                'account_id' => auth()->user()->account->id,
+                'activity_id' => $activity->id,
+                'contacts' => $arrayParticipants,
+            ]);
+        } catch (ModelNotFoundException $e) {
+            return $this->respondNotFound();
+        }
+
+        return new ActivityResource($activity);
+    }
+
+    /**
+     * Delete the activity.
+     *
+     * @param Request $request
+     * @param Contact $contact
+     * @param int $activityId
+     * @return bool|null|\Illuminate\Http\JsonResponse
+     */
+    public function destroy(Request $request, Contact $contact, $activityId)
+    {
+        $data = [
+            'account_id' => auth()->user()->account->id,
+            'activity_id' => $activityId,
+        ];
+
+        try {
+            app(DestroyActivity::class)->execute($data);
+        } catch (ModelNotFoundException $e) {
+            return $this->respondNotFound();
+        }
+    }
+
+    /**
+     * Get the list of activity categories.
+     *
+     * @param Request $request
+     * @return Collection
+     */
+    public function categories(Request $request)
+    {
+        $categories = auth()->user()->account->activityTypeCategories;
+
+        $array = collect([]);
+        foreach ($categories as $category) {
+            $types = ActivityType::where('activity_type_category_id', $category->id)->get();
+
+            $typeCollection = collect([]);
+            foreach ($types as $type) {
+                $typeCollection->push([
+                    'id' => $type->id,
+                    'name' => $type->name,
+                ]);
+            }
+
+            $array->push([
+                'id' => $category->id,
+                'name' => $category->name,
+                'types' => $typeCollection,
+            ]);
+        }
+
+        return $array;
+    }
+
+    /**
+     * Display the summary of activities for a given contact.
+     *
+     * @param Request $request
+     * @param Contact $contact
+     * @return \Illuminate\Http\RedirectResponse
+     */
+    public function summary(Request $request, Contact $contact)
     {
         // get the year of the most recent activity done with the contact
-        $year = $contact->activities->sortByDesc('date_it_happened')->first()->date_it_happened->year;
+        $year = $contact->activities->sortByDesc('happened_at')
+                        ->first()
+                        ->happened_at
+                        ->year;
 
         return redirect()->route('people.activities.year', [$contact, $year]);
     }
@@ -54,7 +209,7 @@ class ActivitiesController extends Controller
                         ->activitiesPerMonthForYear($contact, $year)
                         ->sortByDesc('month');
 
-        return view('people.activities.index')
+        return view('people.activities.year')
             ->withTotalActivities($contact->activities->count())
             ->withActivitiesLastTwelveMonths($activitiesLastTwelveMonths)
             ->withUniqueActivityTypes($uniqueActivityTypes)