Improve IHttpClient factories (#20)

Codestyle fixes
Setup CODEOWNERS
Setup dependabot

SystemExtensions.NetStandard.DependencyInjection/Http/HttpClientBuilder.cs

@@ -0,0 +1,85 @@
+using Slim;
+using System.Extensions;
+using System.Net.Http;
+using System.Net.Http.Headers;
+
+namespace System.DependencyInjection.Http;
+
+public sealed class HttpClientBuilder<T>
+{
+    private readonly IServiceProducer serviceProducer;
+
+    private Uri baseAddress;
+    private HttpMessageHandler httpMessageHandler;
+    private bool disposeMessageHandler;
+    private Action<HttpRequestHeaders> defaultRequestHeadersSetup;
+    private long maxResponseBufferSize = 2147483647L; //2GB default HttpClient value [https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclient.maxresponsecontentbuffersize?view=net-6.0]
+    private TimeSpan timeout = TimeSpan.FromSeconds(100); //100 seconds default HttpClient value [https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclient.timeout?view=net-6.0]
+
+    internal HttpClientBuilder(IServiceProducer serviceProducer)
+    {
+        serviceProducer.ThrowIfNull(nameof(serviceProducer));
+
+        this.serviceProducer = serviceProducer;
+    }
+
+    public HttpClientBuilder<T> WithMessageHandler(HttpMessageHandler httpMessageHandler)
+    {
+        httpMessageHandler.ThrowIfNull(nameof(httpMessageHandler));
+
+        this.httpMessageHandler = httpMessageHandler;
+        return this;
+    }
+
+    public HttpClientBuilder<T> WithDisposeMessageHandler(bool disposeMessageHandler)
+    {
+        this.disposeMessageHandler = disposeMessageHandler;
+        return this;
+    }
+
+    public HttpClientBuilder<T> WithBaseAddress(Uri baseAddress)
+    {
+        baseAddress.ThrowIfNull(nameof(baseAddress));
+
+        this.baseAddress = baseAddress;
+        return this;
+    }
+
+    public HttpClientBuilder<T> WithDefaultRequestHeadersSetup(Action<HttpRequestHeaders> setup)
+    {
+        setup.ThrowIfNull(nameof(setup));
+
+        this.defaultRequestHeadersSetup = setup;
+        return this;
+    }
+
+    public HttpClientBuilder<T> WithMaxResponseBufferSize(long responseBufferSize)
+    {
+        this.maxResponseBufferSize = responseBufferSize;
+        return this;
+    }
+
+    public HttpClientBuilder<T> WithTimeout(TimeSpan timeout)
+    {
+        this.timeout = timeout;
+        return this;
+    }
+
+    public IServiceProducer Build()
+    {
+        this.serviceProducer.RegisterScoped<IHttpClient<T>>(_ =>
+        {
+            var client = this.httpMessageHandler is not null ?
+                new HttpClient<T>(this.httpMessageHandler, this.disposeMessageHandler) :
+                new HttpClient<T>();
+
+            client.BaseAddress = this.baseAddress;
+            this.defaultRequestHeadersSetup?.Invoke(client.DefaultRequestHeaders);
+            client.MaxResponseContentBufferSize = this.maxResponseBufferSize;
+            client.Timeout = this.timeout;
+            return client;
+        });
+
+        return this.serviceProducer;
+    }
+}

SystemExtensions.NetStandard.DependencyInjection/Http/HttpClientResolver.cs

@@ -2,46 +2,46 @@
 using System.Linq;
 using System.Net.Http;
 
-namespace System.Http
+namespace System.Http;
+
+[Obsolete($"Please use {nameof(Extensions.ServiceManagerExtensions.RegisterHttpClient)} for each use case of {nameof(IHttpClient<object>)}")]
+public sealed class HttpClientResolver : IDependencyResolver
 {
-    public sealed class HttpClientResolver : IDependencyResolver
+    private static readonly Type clientType = typeof(HttpClient<>);
+
+    /// <summary>
+    /// Factory method. <see cref="Type"/> parameter of the factory is the scope of <see cref="IHttpClient{TScope}"/>.
+    /// </summary>
+    public Func<Slim.IServiceProvider, Type, HttpMessageHandler> HttpMessageHandlerFactory { get; set; }
+
+    /// <summary>
+    /// Sets the <see cref="HttpMessageHandlerFactory"/>.
+    /// </summary>
+    /// <param name="factory">Factory method. <see cref="Type"/> parameter of the factory is the scope of <see cref="IHttpClient{TScope}"/>.</param>
+    /// <returns></returns>
+    public HttpClientResolver WithHttpMessageHandlerFactory(Func<Slim.IServiceProvider, Type, HttpMessageHandler> factory)
     {
-        private static readonly Type clientType = typeof(HttpClient<>);
+        this.HttpMessageHandlerFactory = factory;
+        return this;
+    }
 
-        /// <summary>
-        /// Factory method. <see cref="Type"/> parameter of the factory is the scope of <see cref="IHttpClient{TScope}"/>.
-        /// </summary>
-        public Func<Slim.IServiceProvider, Type, HttpMessageHandler> HttpMessageHandlerFactory { get; set; }
-
-        /// <summary>
-        /// Sets the <see cref="HttpMessageHandlerFactory"/>.
-        /// </summary>
-        /// <param name="factory">Factory method. <see cref="Type"/> parameter of the factory is the scope of <see cref="IHttpClient{TScope}"/>.</param>
-        /// <returns></returns>
-        public HttpClientResolver WithHttpMessageHandlerFactory(Func<Slim.IServiceProvider, Type, HttpMessageHandler> factory)
+    public bool CanResolve(Type type)
+    {
+        if (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(IHttpClient<>))
         {
-            this.HttpMessageHandlerFactory = factory;
-            return this;
+            return true;
         }
 
-        public bool CanResolve(Type type)
-        {
-            if (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(IHttpClient<>))
-            {
-                return true;
-            }
+        return false;
+    }
 
-            return false;
-        }
-
-        public object Resolve(Slim.IServiceProvider serviceProvider, Type type)
-        {
-            var typedClientType = clientType.MakeGenericType(type.GetGenericArguments());
-            var handler = this.HttpMessageHandlerFactory?.Invoke(serviceProvider, type.GetGenericArguments().First());
-            var httpClient = handler is null ?
-                Activator.CreateInstance(typedClientType) :
-                Activator.CreateInstance(typedClientType, new object[] { handler });
-            return httpClient;
-        }
+    public object Resolve(Slim.IServiceProvider serviceProvider, Type type)
+    {
+        var typedClientType = clientType.MakeGenericType(type.GetGenericArguments());
+        var handler = this.HttpMessageHandlerFactory?.Invoke(serviceProvider, type.GetGenericArguments().First());
+        var httpClient = handler is null ?
+            Activator.CreateInstance(typedClientType) :
+            Activator.CreateInstance(typedClientType, new object[] { handler });
+        return httpClient;
     }
 }