Commit Graph
17616 Commits
Author SHA1 Message Date
dPandCharles Pigott 3cfb8524f0 Fix: Set invalid road and tram types for rail tunnel ends 2020-08-09 18:53:55 +01:00
Łukasz HryniukandCharles Pigott a9aa636b40 Fix: Properly invalidate mouse-over station coverage highlight (#8263) 2020-08-09 18:53:55 +01:00
stormconeandCharles Pigott cb5a1300ac Fix #8250: [NRT] Company infrastructure window always omits last road/tramtype 2020-08-09 18:53:55 +01:00
Charles Pigott 536184e21f Change: Also make roadside trees match the tree transparency option 2020-08-09 18:53:55 +01:00
Charles Pigott 97504e7c29 Fix #8216: Don't show floating text on autoreplace if cost is 0 2020-08-09 18:53:55 +01:00
Charles Pigott 24960b4641 Fix #8129: Crash if a news message expires while viewing the endgame screen 2020-08-09 18:53:55 +01:00
glx22andCharles Pigott 482974b9fe Fix #8230: Resolve ".." when opening files in .tar (#8231) 2020-08-09 18:53:55 +01:00
Jonathan G RennisonandCharles Pigott 4b1070cf75 Fix: Racy use of flags in TCPConnecter::CheckCallbacks
conected and aborted flags are used concurrently from multiple threads.
2020-08-09 18:53:55 +01:00
Jonathan G RennisonandCharles Pigott b827e2415b Fix: Thread unsafe use of NetworkAddress::GetAddressAsString
Remove static buffer form of NetworkAddress::GetAddressAsString.
This is used in multiple threads concurrently, and is not thread-safe.

Replace it with a form returning std::string.
2020-08-09 18:53:55 +01:00
Jonathan G RennisonandCharles Pigott c10571d7ce Fix: Thread unsafe use of SendPacket for PACKET_SERVER_MAP_SIZE
NetworkTCPSocketHandler::SendPacket is not thread safe and may not
be used concurrently from multiple threads without suitable locking
2020-08-09 18:53:55 +01:00
nikolasandCharles Pigott d662e8ca96 Fix #8104: Always add WINDOW_RESIZABLE flag to SDL2 (#8211)
This fixes a bug that can reproduced with these steps:
* Start openttd in fullscreen mode
* Turn off fullscreen mode
* Try to resize the window. The window can't be resized.
2020-08-09 18:53:55 +01:00
Miguel HortaandCharles Pigott 762f5d258a Fix: Display banlist's indexes correctly
Bug introduced via commit ab711e6942
2020-08-09 18:53:55 +01:00
Marcus Calhoun-LopezandCharles Pigott b7fa118069 Fix: unbreak building with ICU on macOS
A symbol clash breaks building ICU on macOS, and although it isn't
necessary, it might as well be possible.
2020-08-09 18:53:55 +01:00
ilayaraja97andCharles Pigott 211735de3a Fix #8131: small bridges also have pillars drawn 2020-08-09 18:53:55 +01:00
Charles Pigott 20007fd1f4 Update: Backport languages 2020-06-01 22:16:57 +01:00
Niels Martin HansenandCharles Pigott 02980119e4 Fix #8066: Try another fallback colourspace if first one fails 2020-06-01 22:16:57 +01:00
YexoandCharles Pigott dd4aae830d Fix #8166: don't crash on loading an invalid roadtype newgrf
Initialization code for GRFFile::roadtype_map was copied from
railtype_map. But while RailType is a byte-sized enum and could thus
be initialized via memset, RoadType doesn't have a defined size.
2020-06-01 22:16:57 +01:00
YexoandCharles Pigott f4ed770cff Fix #8024: make online content gui more responsive while loading
Previously the internal content list was invalidated and sorted for
every new item added. Now the sorting is delayed until the GUI is
drawn, which means we only sort once per GUI tick.

Since the amount of incoming items per GUI tick is not controlled by
the GUI but rather by network speed, we were previously doing a lot
of duplicate work per tick, causing the mouse cursor to lag while
the list was initialized.
2020-06-01 22:16:57 +01:00
glxandCharles Pigott 89c8215b79 Fix: [Win32] Crash message not fitting in crash dialog 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 911f9165cf Fix #7970: [Win32] Disable event loop on crash to prevent recursive faults 2020-06-01 22:16:57 +01:00
dPandCharles Pigott 31a9f549fb Fix: Trees disappear completely after a few years when they're not allowed to spread 2020-06-01 22:16:57 +01:00
YexoandCharles Pigott 3d8e68f966 Fix #8155: Roadtype speed limit in toolbar dropdown in scenario editor was doubled 2020-06-01 22:16:57 +01:00
dPandCharles Pigott fd8ca95947 Fix: Desync after house replacement 2020-06-01 22:16:57 +01:00
glx22andCharles Pigott 74b591c2e9 Fix #8142, 5aa6351: Buoy owner and tile owner can be different (#8143) 2020-06-01 22:16:57 +01:00
dPandCharles Pigott 78e558717c Fix #8137: New clients can't join (desync) after funding an industry 2020-06-01 22:16:57 +01:00
dPandCharles Pigott cb9c4bf4a0 Codechange: Refactor FindStationsAroundTiles to avoid code duplication 2020-06-01 22:16:57 +01:00
glx22andCharles Pigott e39c5829a2 Add: stations_near and industries_near cache check (#8139) 2020-06-01 22:16:57 +01:00
glxandCharles Pigott a089c876ab Fix #8132: Corrupted savegame crashing OpenTTD on load 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 1072c74bc4 Fix: Stop any gamelog action when recovering from SlError() 2020-06-01 22:16:57 +01:00
glxandCharles Pigott bb251f45fc Fix #8119: Update docking area when clearing a shore rail tile 2020-06-01 22:16:57 +01:00
Niels Martin HansenandCharles Pigott 3132d29805 Fix: Two issues in MIDI file writer
Variable-length values would write threshold values with a byte too many.
System Exclusive messages would cause write to fail since the end byte was treated as part of next message.
2020-06-01 22:16:57 +01:00
SamuXarickandCharles Pigott 94581d352a Fix #8119, f538179: Update docking tile area when placing a diagonal rail next to a dock end (#8124) 2020-06-01 22:16:57 +01:00
glx22andCharles Pigott cf27deb675 Fix #8117: Memory leak in admin port (#8122) 2020-06-01 22:16:57 +01:00
glx22andCharles Pigott 40d68273aa Add: docking tiles cache check (#8120) 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 2cc244bde0 Fix #8021: limit savegame range for docking tiles fixing 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 22519b3b0d Update: Lang files 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 5b2447e10c Codechange: Use a dynamic copyright year 2020-06-01 22:16:57 +01:00
YexoandCharles Pigott e0680c9ede Fix: reset roadtype/streetcartype info for non-road bridges 2020-06-01 22:16:57 +01:00
YexoandCharles Pigott ea895f05eb Fix #8108: always update tile_hash after updating v->tile 2020-06-01 22:16:57 +01:00
SamuXarickandCharles Pigott 37187df7ef Fix c01a2e2: crash on loading old savegames with invalid animated tile information 2020-06-01 22:16:57 +01:00
froschandCharles Pigott 4297cc5f21 Fix #8093: Build+Refit changed game-state in command test run, and thus caused desyncs.
Use DC_AUTOREPLACE for actions that shall be reversibe, in this case:
- Do not rearrange free wagons in test-run.
- Do not discard OrderBackups.
The latter was not triggered by actual auto-replace, since it does not set a 'user'.
2020-06-01 22:16:57 +01:00
froschandCharles Pigott 591ca82845 Fix: When build+refit an engine, do not refit any free wagons that may get attached. 2020-06-01 22:16:57 +01:00
froschandCharles Pigott e90322f6e9 Codechange: Unify the tests whether build+refit is in simulation-test or real-run. 2020-06-01 22:16:57 +01:00
SamuXarickandCharles Pigott 978cc774ec Fix: [Script] ScriptMarine::AreWaterTilesConnected failed for aqueducts (#8074) 2020-06-01 22:16:57 +01:00
glxandCharles Pigott 2bf936bbbc Fix #8081: Check for waypoints when removing docking tiles 2020-04-13 18:39:51 +01:00
Pavel StupnikovandCharles Pigott eb8d79f41f Fix a5681d3e: Make goal question ID use 16 bits again (#8072) 2020-04-13 18:39:51 +01:00
glxandCharles Pigott 0737458ec4 Fix #8064: Incorrect display of refit capacity 2020-04-13 18:39:51 +01:00
froschandCharles Pigott 7e659bc3da Fix #8060, 5880f14: Restore admin network API compatibility. 2020-04-13 18:39:51 +01:00
stormconeandCharles Pigott 612c912144 Fix #8055, c02ef3e: Crash when roadtype availability changed with the road toolbar open (#8058) 2020-04-13 18:39:51 +01:00
Charles Pigott c8cd5f7f3a Doc: Prepare for 1.10.0 release 2020-03-31 23:08:53 +01:00