amacocian/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2026-07-24 03:56:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Codefix: wrong parameter names and partially missing parameters

Browse Source
This commit is contained in:
Rubidium
2026-02-01 08:14:02 +01:00
committed by rubidium42
parent f25e1f8be1
commit c6c06e13eb
73 changed files with 206 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/strings.cpp
+11 -5
View File
@@ -406,7 +406,7 @@ void GetStringWithArgs(StringBuilder &builder, StringID string, StringParameters
* Get a parsed string with most special stringcodes replaced by the string parameters.
* @param builder The builder of the string.
* @param string The ID of the string to parse.
* @param args Span of arguments for the string.
* @param params Span of arguments for the string.
* @param case_index The "case index". This will only be set when FormatString wants to print the string in a different case.
* @param game_script The string is coming directly from a game script.
*/
@@ -962,7 +962,8 @@ static const Units GetVelocityUnits(VehicleType type)
/**
* Convert the given (internal) speed to the display speed.
* @param speed the speed to convert
* @param speed The speed to convert.
* @param type The associated vehicle type.
* @return the converted speed.
*/
uint ConvertSpeedToDisplaySpeed(uint speed, VehicleType type)
@@ -975,7 +976,8 @@ uint ConvertSpeedToDisplaySpeed(uint speed, VehicleType type)
/**
* Convert the given display speed to the (internal) speed.
* @param speed the speed to convert
* @param speed The speed to convert.
* @param type The associated vehicle type.
* @return the converted speed.
*/
uint ConvertDisplaySpeedToSpeed(uint speed, VehicleType type)
@@ -985,7 +987,8 @@ uint ConvertDisplaySpeedToSpeed(uint speed, VehicleType type)
/**
* Convert the given km/h-ish speed to the display speed.
* @param speed the speed to convert
* @param speed The speed to convert.
* @param type The associated vehicle type.
* @return the converted speed.
*/
uint ConvertKmhishSpeedToDisplaySpeed(uint speed, VehicleType type)
@@ -995,7 +998,8 @@ uint ConvertKmhishSpeedToDisplaySpeed(uint speed, VehicleType type)
/**
* Convert the given display speed to the km/h-ish speed.
* @param speed the speed to convert
* @param speed The speed to convert.
* @param type The associated vehicle type.
* @return the converted speed.
*/
uint ConvertDisplaySpeedToKmhishSpeed(uint speed, VehicleType type)
@@ -1099,6 +1103,8 @@ static bool IsColourSafe(std::string_view buffer)
* @param builder The string builder to write the final string to.
* @param str_arg The original string with format codes.
* @param args Pointer to extra arguments used by various string codes.
* @param orig_case_index The selected case when entering the function.
* @param game_script Whether this string originates from a game-script.
* @param dry_run True when the args' type data is not yet initialized.
*/
static void FormatString(StringBuilder &builder, std::string_view str_arg, StringParameters &args, uint orig_case_index, bool game_script, bool dry_run)