From 384fdaf67c901b21ceb4fc3fd0ad5f30ad305ea3 Mon Sep 17 00:00:00 2001
From: Macocian Alexandru Victor <amacocian@yahoo.com>
Date: Thu, 26 Feb 2026 14:07:00 -0800
Subject: [PATCH] Fix tests (#1487)

---
 .../Services/BuildTemplateManagerTests.cs     | 180 ++----------------
 1 file changed, 11 insertions(+), 169 deletions(-)

diff --git a/Daybreak.Tests/Services/BuildTemplateManagerTests.cs b/Daybreak.Tests/Services/BuildTemplateManagerTests.cs
index b49ca693..1f84bfa1 100644
--- a/Daybreak.Tests/Services/BuildTemplateManagerTests.cs
+++ b/Daybreak.Tests/Services/BuildTemplateManagerTests.cs
@@ -1,6 +1,7 @@
 using Daybreak.Shared.Models.Builds;
 using Daybreak.Shared.Models.Guildwars;
 using Daybreak.Shared.Services.BuildTemplates;
+using Daybreak.Shared.Services.BuildTemplates.Parsers;
 using FluentAssertions;
 using Microsoft.Extensions.Logging;
 using NSubstitute;
@@ -12,13 +13,14 @@ namespace Daybreak.Tests.Services;
 public class BuildTemplateManagerTests
 {
     private const string EncodedSingleTemplate = "OwBk0texXNu0Dj/z+TDzBj+TN4AE";
-    private const string EncodedTeamTemplate = "OQJUAMxOEMLnw0nDXQGY6aw2B OQNCA8wDP9B8DyzmOUi1veC OggjYxXTIPWbp5krZfxEAAAoD OwUTM4HDn5gc9TJSh6xddmETA";
+    private const string EncodedTeamTemplate = "OQJUAMxOEMLnw0nDXQGY6aw2B OQNCA8wDP9B8DyzmOUi1veC OggjcNWcIPWbp5krZfxEAAAoD OwUTAnHP45gc9TJSh6xddmETA";
     private BuildTemplateManager buildTemplateManager = default!;
 
     [TestInitialize]
     public void Initialize()
     {
-        this.buildTemplateManager = new BuildTemplateManager(Substitute.For<ILogger<BuildTemplateManager>>());
+        ITemplateParser[] templateParsers = [new SkillTemplateParser(), new LegacySkillTemplateParser(), new PartyLoadoutTemplateParser()];
+        this.buildTemplateManager = new BuildTemplateManager(templateParsers, Substitute.For<ILogger<BuildTemplateManager>>());
     }
 
     [TestMethod]
@@ -30,14 +32,14 @@ public class BuildTemplateManagerTests
         singleBuildEntry.Primary.Should().Be(Profession.Assassin);
         singleBuildEntry.Secondary.Should().Be(Profession.None);
         singleBuildEntry.Attributes.Count.Should().Be(4);
-        singleBuildEntry.Attributes[1].Attribute.Should().Be(Attribute.DaggerMastery);
-        singleBuildEntry.Attributes[1].Points.Should().Be(11);
-        singleBuildEntry.Attributes[2].Attribute.Should().Be(Attribute.DeadlyArts);
-        singleBuildEntry.Attributes[2].Points.Should().Be(1);
-        singleBuildEntry.Attributes[3].Attribute.Should().Be(Attribute.ShadowArts);
-        singleBuildEntry.Attributes[3].Points.Should().Be(5);
-        singleBuildEntry.Attributes[0].Attribute.Should().Be(Attribute.CriticalStrikes);
+        singleBuildEntry.Attributes[0].Attribute.Should().Be(Attribute.DaggerMastery);
         singleBuildEntry.Attributes[0].Points.Should().Be(11);
+        singleBuildEntry.Attributes[1].Attribute.Should().Be(Attribute.DeadlyArts);
+        singleBuildEntry.Attributes[1].Points.Should().Be(1);
+        singleBuildEntry.Attributes[2].Attribute.Should().Be(Attribute.ShadowArts);
+        singleBuildEntry.Attributes[2].Points.Should().Be(5);
+        singleBuildEntry.Attributes[3].Attribute.Should().Be(Attribute.CriticalStrikes);
+        singleBuildEntry.Attributes[3].Points.Should().Be(11);
         singleBuildEntry.Skills.Count.Should().Be(8);
         singleBuildEntry.Skills[0].Should().Be(Skill.UnsuspectingStrike);
         singleBuildEntry.Skills[1].Should().Be(Skill.WildStrike);
@@ -73,26 +75,11 @@ public class BuildTemplateManagerTests
                 Points = 11
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.IllusionMagic,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.InspirationMagic,
                 Points = 2
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.BeastMastery,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.Marksmanship,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.WildernessSurvival,
                 Points = 12
@@ -121,35 +108,10 @@ public class BuildTemplateManagerTests
                 Points = 12
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.DominationMagic,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.IllusionMagic,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.InspirationMagic,
                 Points = 12
             },
-            new AttributeEntry
-            {
-                Attribute = Attribute.HealingPrayers,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.SmitingPrayers,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.ProtectionPrayers,
-                Points = 0
-            },
         ]);
         secondBuild.Skills.Should().BeEquivalentTo(
         [
@@ -179,26 +141,6 @@ public class BuildTemplateManagerTests
                 Points = 12
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.Marksmanship,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.WildernessSurvival,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.ChannelingMagic,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.Communing,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.RestorationMagic,
                 Points = 12
@@ -227,31 +169,11 @@ public class BuildTemplateManagerTests
                 Points = 3
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.HealingPrayers,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.SmitingPrayers,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.ProtectionPrayers,
                 Points = 12
             },
             new AttributeEntry
-            {
-                Attribute = Attribute.DominationMagic,
-                Points = 0
-            },
-            new AttributeEntry
-            {
-                Attribute = Attribute.IllusionMagic,
-                Points = 0
-            },
-            new AttributeEntry
             {
                 Attribute = Attribute.InspirationMagic,
                 Points = 12
@@ -339,26 +261,11 @@ public class BuildTemplateManagerTests
                             Points = 11
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.IllusionMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.InspirationMagic,
                             Points = 2
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.BeastMastery,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.Marksmanship,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.WildernessSurvival,
                             Points = 12
@@ -386,35 +293,10 @@ public class BuildTemplateManagerTests
                             Points = 12
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.DominationMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.IllusionMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.InspirationMagic,
                             Points = 12
                         },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.HealingPrayers,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.SmitingPrayers,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.ProtectionPrayers,
-                            Points = 0
-                        },
                     ],
                     Skills = [
                         Skill.SymbolicCelerity,
@@ -443,26 +325,6 @@ public class BuildTemplateManagerTests
                             Points = 12
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.Marksmanship,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.WildernessSurvival,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.ChannelingMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.Communing,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.RestorationMagic,
                             Points = 12
@@ -490,31 +352,11 @@ public class BuildTemplateManagerTests
                             Points = 3
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.HealingPrayers,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.SmitingPrayers,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.ProtectionPrayers,
                             Points = 12
                         },
                         new AttributeEntry
-                        {
-                            Attribute = Attribute.DominationMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
-                        {
-                            Attribute = Attribute.IllusionMagic,
-                            Points = 0
-                        },
-                        new AttributeEntry
                         {
                             Attribute = Attribute.InspirationMagic,
                             Points = 12